Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Email fixes #38

Merged
merged 16 commits into from
Jan 23, 2024
Merged

Email fixes #38

merged 16 commits into from
Jan 23, 2024

Conversation

hatch01
Copy link
Member

@hatch01 hatch01 commented Jan 20, 2024

Fixed ui to send email:

  • now editing bar is on the bottom sticked to the keyboard
  • the attachments are so moved to the top of the screen
  • the ui is as much as I can responsive and use less fixed sizes
  • sending attachments work back
  • there is now an indicator to say that the email is sending and sended

in reading email:

  • fixed the background color of the web view in dark-reader

in logic :

  • deleted some duplicate code in email cubit
  • use a send cubit to easily share controller etc

@FlashOnFire
Copy link
Collaborator

Would it be possible to also fix the bug where sent emails don't show in the "Sent Emails" tab ?
The changelog seems great otherwise

@hatch01
Copy link
Member Author

hatch01 commented Jan 20, 2024

Would it be possible to also fix the bug where sent emails don't show in the "Sent Emails" tab ? The changelog seems great otherwise

I forgot it in the message but it is done !

hatch01
hatch01 commented Jan 23, 2024
View reviewed changes
Copy link
Member Author

@hatch01 hatch01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed myself

@hatch01 hatch01 merged commit 1721116 into dev Jan 23, 2024
0 of 5 checks passed
@hatch01 hatch01 deleted the email_fixes branch January 23, 2024 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hatch01 @FlashOnFire